Don't error on symlinks and executables when they don't have to be touched anyway #46
+524
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related: changesets/action#523 |
…uched anyway Co-authored-by: Dotan Simha <dotan@the-guild.dev>
Andarist
force-pushed
the
Andarist-patch-1
branch
from
e18d89a to
104ac00
Compare
s0
previously approved these changes
Jan 13, 2026
Member
|
Looks good, but integration tests need to be updated to allow for unchanged symlinks, but still throw an error for symlinks that changed and are not ignored. |
s0
previously approved these changes
Jan 14, 2026
Member
|
Hmm tests still failing |
Member
Author
|
@s0, ye - I vibocoded them and couldn't quickly test locally because I didn't have tokens setup for the integration tests so decided to use CI to verify the change for me ;p I'll look into fixing this later |
Member
Author
|
In the process of working on this I have diagnosed an issue in the |
Andarist
force-pushed
the
Andarist-patch-1
branch
4 times, most recently
from
bf3055e to
6c8c084
Compare
Andarist
force-pushed
the
Andarist-patch-1
branch
from
0afc309 to
af4c42d
Compare
Andarist
force-pushed
the
Andarist-patch-1
branch
from
7fecc15 to
a1a7daf
Compare
Andarist
force-pushed
the
Andarist-patch-1
branch
from
a1a7daf to
bcf398e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggested by @dotansimha